-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more configurable options via env vars (6.1.x) #158
Conversation
Co-authored-by: David Glick <[email protected]>
Instead of blowing this up here I would go for using |
@jensens I like that idea, but we also need to be careful we don't break things if cookiecutter-zope-instance uses different environment variable names from the ones that have been here for some time. Maybe someone can investigate at the Alpine City sprint? Also note I already merged the same change to the 6.0.x branch |
It uses different names, indeed. We could add a compat layer and deprecate the old names for a while. +1 for more at ACS |
Requested change has been done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the same PR on 6.0.x was already approved and merged, I will do the same here. Afterwards I will make a PR for 6.1.0rc1 which is now ready.
See #153 for discussion